-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp/cadvisor): allow user to disable collecting root Cgroup stats #5713
feat(comp/cadvisor): allow user to disable collecting root Cgroup stats #5713
Conversation
Signed-off-by: hainenber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs are OK as-is
I've merged grafana/cadvisor#2 (thanks for taking care of it!) so let's also update go.mod as well. LGTM as far as the PR is progressing right now. |
cc @hainenber when you have some time, can we update go.mod to point at the your grafana/cadvisor#2 change so we can go ahead with this? |
Signed-off-by: hainenber <[email protected]>
@tpaschalis hey there, sorry for the delay, life caught up with me :D I've updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…ts (grafana#5713) Signed-off-by: hainenber <[email protected]>
PR Description
Allow user to specify whether
cadvisor
to collect rootcgroup
statisticsWhich issue(s) this PR fixes
Fixes #5700
Notes to the Reviewer
Please help checking grafana/cadvisor#2 as it's required for this PR to go through. Thanks!
PR Checklist