feat(comp/cadvisor): allow user to disable collecting root Cgroup stats #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
clayton-cornell
added
the
type/docs
|
I've merged grafana/cadvisor#2 (thanks for taking care of it!) so let's also update go.mod as well. LGTM as far as the PR is progressing right now. |
|
cc @hainenber when you have some time, can we update go.mod to point at the your grafana/cadvisor#2 change so we can go ahead with this? |
Signed-off-by: hainenber <[email protected]>
|
@tpaschalis hey there, sorry for the delay, life caught up with me :D I've updated |
hainenber
added a commit
to hainenber/agent
that referenced
this pull request
Nov 25, 2023
…ts (grafana#5713) Signed-off-by: hainenber <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Allow user to specify whether
cadvisorto collect rootcgroupstatisticsWhich issue(s) this PR fixes
Fixes #5700
Notes to the Reviewer
Please help checking grafana/cadvisor#2 as it's required for this PR to go through. Thanks!
PR Checklist