Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String conversion perf improvements + minor unrelated changes #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

String conversion perf improvements + minor unrelated changes #54

wants to merge 4 commits into from

Commits on Oct 29, 2019

  1. Improve performance of string conversion 

    Convert to string with one call to snprintf and no string concatenations
instead of 5 calls to snprintf and 8 concatenations. Microbenchmarks
indicate that this is approximately 17% faster (1.17 times as fast).
    @louiswins
    louiswins committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    23a8c00 View commit details
    Browse the repository at this point in the history

  2. Explicitly discard CoCreateGuid HRESULT 

    On MSDN it is marked as only being able to return S_OK, but in
combaseapi.h it is still marked _Check_result_. This will cause a
warning if you have them cranked up high enough.
    @louiswins
    louiswins committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    903c351 View commit details
    Browse the repository at this point in the history

  3. Mark a couple functions static 

    This could theoretically open up some optimizations, but mostly it's
just good hygiene.
    @louiswins
    louiswins committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    9b51a5d View commit details
    Browse the repository at this point in the history

  4. Clearer names for locals

    @louiswins
    louiswins committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    1ef5038 View commit details
    Browse the repository at this point in the history