Skip to content

Commit

Permalink
Optimize SLF4J dependencies for all modules
Browse files Browse the repository at this point in the history
No need to add SLF4J dependencies to all modules

* Remove SLF4J dependencies from all modules
* Add `org.slf4j:jcl-over-slf4j` to `grace-shell`

Closes gh-471
  • Loading branch information
rainboyan committed Aug 15, 2024
1 parent 19d0dcc commit a13ec34
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
9 changes: 1 addition & 8 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ if (jointBuildGroovyJarProperty) {
throw new GradleException("The groovy.jar system property points to ${jointBuildGroovyJar.absolutePath} which does not exist.")
}
} else {
groovyDependency = dependencies.create("org.codehaus.groovy:groovy:${groovyVersion}") {
exclude module:"commons-cli"
exclude module:"ant"
}
groovyDependency = dependencies.create("org.codehaus.groovy:groovy:${groovyVersion}")
}

version = grailsVersion
Expand Down Expand Up @@ -320,10 +317,6 @@ subprojects { project ->
testRuntimeOnly libs.junit.jupiter.engine

if (project.name != "grace-docs") {
// Logging
api libs.slf4j.api
api libs.slf4j.jcl

// Testing
testImplementation libs.slf4j.simple
testImplementation libs.spock.core, { transitive = false }
Expand Down
2 changes: 2 additions & 0 deletions grace-shell/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ dependencies {
compileOnly libs.spring.web
api libs.jansi
api libs.jline
api libs.slf4j.api
api libs.slf4j.jcl
dependenciesBom project(path: ":grace-bom", configuration: 'effectiveBom')
implementation(libs.maven.resolver.provider) {
exclude group: "com.google.guava", module: "guava"
Expand Down

0 comments on commit a13ec34

Please sign in to comment.