Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add import assertion for json modules #363

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix: add import assertion for json modules #363

merged 1 commit into from
Feb 23, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Feb 22, 2024 •
edited
Loading

In this PR:

  • add the with {type: 'json'} assertion to JSON module imports in order to comply when running those modules in other projects.

@spaenleh spaenleh self-assigned this Feb 22, 2024
@spaenleh spaenleh added build Build and developer operations chore Generic task or chore labels Feb 22, 2024
ReidyT
ReidyT approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that, it's interesting !

@spaenleh spaenleh merged commit 54e5be3 into main Feb 23, 2024
2 checks passed
@spaenleh spaenleh deleted the use-with-for-json-imports branch February 23, 2024 11:40
@github-actions github-actions bot mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@spaenleh spaenleh

Labels
build Build and developer operations chore Generic task or chore v1.25.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @ReidyT