Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Fix javax.crypto.JceSecurity substitutions in JDK >= 17.0.10 #609

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[23.0] Fix javax.crypto.JceSecurity substitutions in JDK >= 17.0.10 #609

merged 1 commit into from
Nov 9, 2023

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Nov 9, 2023

Closes #607

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 9, 2023
@zakkak zakkak force-pushed the 2023-11-09-fix-607 branch from 4ceec14 to 7525932 Compare November 9, 2023 10:11
@zakkak zakkak requested a review from jerboaa November 9, 2023 10:11
@zakkak zakkak changed the title Fix javax.crypto.JceSecurity substitutions in JDK >= 17.0.10 [23.0] Fix javax.crypto.JceSecurity substitutions in JDK >= 17.0.10 Nov 9, 2023
@jerboaa jerboaa linked an issue Nov 9, 2023 that may be closed by this pull request
[23.0] Mandrel 23.0 fails to build with JDK 17.0.10-EA #607
Closed
@jerboaa
Copy link
Collaborator

jerboaa commented Nov 9, 2023

Windows CI issues are #612

@zakkak zakkak force-pushed the 2023-11-09-fix-607 branch 2 times, most recently from efaead0 to 0c6ac66 Compare November 9, 2023 14:24
jerboaa
jerboaa approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/SecuritySubstitutions.java Outdated Show resolved Hide resolved
substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/SecurityServicesFeature.java Outdated Show resolved Hide resolved
@zakkak zakkak force-pushed the 2023-11-09-fix-607 branch from 0c6ac66 to f694479 Compare November 9, 2023 14:58
@zakkak zakkak merged commit cedccd0 into graalvm:mandrel/23.0 Nov 9, 2023
68 of 71 checks passed
@zakkak zakkak deleted the 2023-11-09-fix-607 branch November 9, 2023 20:44
@jerboaa jerboaa mentioned this pull request Nov 10, 2023
Closed
@zakkak zakkak added the release/noteworthy-feature A PR that is worth highlighting in the Changelog label Nov 10, 2023
@zakkak zakkak added this to the 23.0.3.0-Final milestone Nov 10, 2023
@simonis simonis mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. release/noteworthy-feature A PR that is worth highlighting in the Changelog
Projects
None yet
Milestone
23.0.3.0-Final
Development

Successfully merging this pull request may close these issues.

[23.0] Mandrel 23.0 fails to build with JDK 17.0.10-EA
2 participants
@zakkak @jerboaa