-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Update nightly builds to use JDK 22 #606
Conversation
7b63176
to
cd6458c
Compare
.github/workflows/nightly.yml
Outdated
@@ -40,34 +51,34 @@ jobs: | |||
version: "graal/master" | |||
build-type: "graal-source" | |||
jdk: "21/ea" | |||
build-stats-tag: "gha-linux-qmain-glatest-jdk21ea" | |||
build-stats-tag: "gha-linux-graal-qmain-glatest-jdk21ea" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW glatest
stands for graal latest and mlatest
for mandrel latest. I know, not the best choice... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aah, yeah hard to spot.
Since mandrel with JDK 22 is also tested on the weekly builds, can you please update them to build with JDK 21 instead?
I suggest we remove the JDK 21 build (or move it to the weekly job), graal builds from source with JDK 21 are being tested nightly in https://github.com/oracle/graal/actions/workflows/quarkus.yml as well |
We test it nightly and using JDK 21 is bound to fail due to graalvm/mandrel/issue/598.
cd6458c
to
973ab2d
Compare
I've disabled JDK 22 builds in the weekly job for now. JDK 21-based mandrel builds are a moot point currently due to #598.
OK, since I don't monitor graal jobs upstream, I prefer having it in the mandrel actions. Moved to the weekly job, which should be sufficient. |
OK, so you suggest we keep them disabled till we have a fix. |
Yes. No point in having known failing CI. It's just noise. |
This PR does the following things:
graal-source
in the JDK 21 modegraal-source
in the JDK 22 config