Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update nightly builds to use JDK 22 #606

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Nov 8, 2023

This PR does the following things:

@jerboaa jerboaa requested a review from zakkak November 8, 2023 18:03
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 8, 2023
@jerboaa jerboaa force-pushed the change_nightly_to_jdk22 branch from 7b63176 to cd6458c Compare November 8, 2023 18:05
@@ -40,34 +51,34 @@ jobs:
version: "graal/master"
build-type: "graal-source"
jdk: "21/ea"
build-stats-tag: "gha-linux-qmain-glatest-jdk21ea"
build-stats-tag: "gha-linux-graal-qmain-glatest-jdk21ea"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW glatest stands for graal latest and mlatest for mandrel latest. I know, not the best choice... :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aah, yeah hard to spot.

@zakkak
Copy link
Collaborator

zakkak commented Nov 8, 2023

Since mandrel with JDK 22 is also tested on the weekly builds, can you please update them to build with JDK 21 instead?

  • Keep building graal-source in the JDK 21 mode
  • Also build graal-source in the JDK 22 config

I suggest we remove the JDK 21 build (or move it to the weekly job), graal builds from source with JDK 21 are being tested nightly in https://github.com/oracle/graal/actions/workflows/quarkus.yml as well

We test it nightly and using JDK 21 is bound to fail due to
graalvm/mandrel/issue/598.
@jerboaa jerboaa force-pushed the change_nightly_to_jdk22 branch from cd6458c to 973ab2d Compare November 9, 2023 14:30
@jerboaa
Copy link
Collaborator Author

jerboaa commented Nov 9, 2023

Since mandrel with JDK 22 is also tested on the weekly builds, can you please update them to build with JDK 21 instead?

I've disabled JDK 22 builds in the weekly job for now. JDK 21-based mandrel builds are a moot point currently due to #598.

  • Keep building graal-source in the JDK 21 mode
  • Also build graal-source in the JDK 22 config

I suggest we remove the JDK 21 build (or move it to the weekly job), graal builds from source with JDK 21 are being tested nightly in https://github.com/oracle/graal/actions/workflows/quarkus.yml as well

OK, since I don't monitor graal jobs upstream, I prefer having it in the mandrel actions. Moved to the weekly job, which should be sufficient.

@zakkak
Copy link
Collaborator

zakkak commented Nov 9, 2023

JDK 21-based mandrel builds are a moot point currently due to #598.

OK, so you suggest we keep them disabled till we have a fix.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Nov 9, 2023

JDK 21-based mandrel builds are a moot point currently due to #598.

OK, so you suggest we keep them disabled till we have a fix.

Yes. No point in having known failing CI. It's just noise.

@zakkak zakkak merged commit b434cef into graalvm:default Nov 9, 2023
212 of 220 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants