Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the SetModeDialDisable opcode for Canon cameras #991

Merged

Conversation

jensanjo
Copy link
Contributor

@jensanjo jensanjo commented Aug 3, 2024

Several Canon EOS cameras allow software setting of the exposure mode dial. This is supported by libgphoto2 via the autoexposuremodedial config.
This works as expected wit for instance the EOS 1200D and the EOS 2000D.
In some Canon cameras, for instance the Canon EOS R50, you need to unlock this feature before it can be used.

The SetModeDialDisable opcode (0x9088) has to be sent to the camera with parameter 0 to disable the mode dial and allow software setting of the exposure mode.
The disabling is cancelled by sending the SetModeDialDisable command with parameter 1.

This pull request will allow software setting of the exposure mode during a camera session by issuing the SetModeDialDisable as described above, by enabling software setting in camera_init and disabling it in camera_exit.

It also adds a disablemodedial camera action config so that the feature can be enabled / disabled during a camera session.

Being able to control the exposure mode via software is a valuable feature for many applications.

This pull request consists of 3 commits:

  • b83256c adds the PTP_OC_CANON_SetModeDialDisable opcode in ptp.h and ptp.c
  • ca24153 adds the enabling/disabling to camera_init and camera_exit for supported cameras
  • 26f4e49 adds disablemodedial command to camera actions for supported cameras

@msmeissn msmeissn added the Canon tagging canon reports label Aug 9, 2024
@msmeissn msmeissn self-assigned this Aug 9, 2024
@msmeissn msmeissn merged commit c58709d into gphoto:master Aug 9, 2024
3 of 4 checks passed
@jensanjo jensanjo deleted the feature-canon_set_mode_dial_disable branch August 14, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Canon tagging canon reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants