Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on Mac OS X #953

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Fix build on Mac OS X #953

merged 2 commits into from
Jan 12, 2024

Conversation

colinleroy
Copy link
Contributor

Fixes #952

@colinleroy
Fix build on Mac OS X
17ba0f0 
Fixes gphoto#952
@colinleroy
Fix FreeBSD build
fd82950 
Include unistd.h in every file calling usleep()
@msmeissn msmeissn merged commit cd9230b into gphoto:master Jan 12, 2024
4 of 5 checks passed
@msmeissn
Copy link
Contributor

thanks, i saw the freebsd failures but was struggling a bit on them

@colinleroy
Copy link
Contributor Author

thanks, i saw the freebsd failures but was struggling a bit on them

Apparently including unistd.h is not enough... Sorry about that, I don't know why!

@msmeissn
Copy link
Contributor

There are some #define _FOO_SOURCE on top of those files, which we thought will help macOS / darwin builds, but they occasionaly block various other standard library functions.

@hfiguiere
Copy link
Member

uint16_t with #include <stdint.h> should be the type used

types like int and short should be left behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'ushort' not compiling correctly on mac
3 participants
@colinleroy @msmeissn @hfiguiere