EOS event naming #1035
Merged
EOS event naming #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EOS event handling code was partly using the term "change_entry" or "entry" when referring to an event. I found this unnecessarily confusing. This is mostly a symbol rename patch: * PTPCanon_changes_entry -> PTPCanonEOSEvent * PTP_CANON_EOS_CHANGES_TYPE_* -> PTP_EOSEvent_* * entry -> event * backlogentries -> eos_events * type -> ec (event code) * proptype -> dpc (device property code) * a few more ptp_unpack internal offset constants renamed
new function ptp_get_eos_event_name()
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly code and log readability improvements + plus a fix for an autofocus regression, I introduced earlier :-/.