Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random fixes 2 #1017

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Random fixes 2 #1017

merged 4 commits into from
Sep 16, 2024

Commits on Sep 15, 2024

  1. more replace sprintf(buf) + strdup(buf) pattern with new aprintf() 

    Overlooked one file during recent commit.
    @axxel
    axxel committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    c4527c6 View commit details
    Browse the repository at this point in the history

  2. fix regression introduced in gphoto#1002 

    At least, I found it myself... :-/

gphoto@5c9d7b2?diff=unified&w=1#diff-bce068530fdda102b15492a416c91c8d1dd7681b28c7443ad53b0241dfcb0068
    @axxel
    axxel committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    6cd2d64 View commit details
    Browse the repository at this point in the history

  3. fix compiler warnings about potentially truncated strings from snprintf

    @axxel
    axxel committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    3cc83c6 View commit details
    Browse the repository at this point in the history

  4. fix a few random compiler warnings 

     * unused variables
 * implicit enum conversion
 * sigend <-> unsigned comparison
 * left shift negative number

The only warnings left on my setup right now are `-Wstringop-truncation`
from strncpy calls. Those are not trivial to fix. Turns out the code does
regularly not take into account that strncpy may not result in a null
terminated string. Details, see `man string_copying`.
    @axxel
    axxel committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    1f55ab5 View commit details
    Browse the repository at this point in the history