Skip to content

Commit

Permalink
disable uuilock/unlocking around pcchdd capacity setting.
Browse files Browse the repository at this point in the history
this irritates the EOS 2000D/1500D to not work and received multiple bug reports
  • Loading branch information
msmeissn committed Sep 2, 2023
1 parent ad30c4f commit 6b3e29f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions camlibs/ptp2/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ camera_canon_eos_update_capture_target(Camera *camera, GPContext *context, int v
"setdevicepropvalue of capturetarget to 0x%x failed", ct_val.u32);
if (ct_val.u32 == PTP_CANON_EOS_CAPTUREDEST_HD) {
uint16_t ret;
#if 0
int uilocked = params->uilocked;

/* if we want to download the image from the device, we need to tell the camera
Expand All @@ -344,9 +345,12 @@ camera_canon_eos_update_capture_target(Camera *camera, GPContext *context, int v

if (!uilocked)
LOG_ON_PTP_E (ptp_canon_eos_setuilock (params));
#endif
ret = ptp_canon_eos_pchddcapacity(params, 0x0fffffff, 0x00001000, 0x00000001);
#if 0
if (!uilocked)
LOG_ON_PTP_E (ptp_canon_eos_resetuilock (params));
#endif
/* not so bad if its just busy, would also fail later. */
if (ret == PTP_RC_DeviceBusy) ret = PTP_RC_OK;
C_PTP (ret);
Expand Down

0 comments on commit 6b3e29f

Please sign in to comment.