Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCMAW-9665: Add /async/token contract testing for IPV Core consumer #63

Merged
merged 41 commits into from
Aug 5, 2024
Merged

DCMAW-9665: Add /async/token contract testing for IPV Core consumer #63

merged 41 commits into from
Aug 5, 2024

Conversation

J-son1
Copy link
Contributor

@J-son1 J-son1 commented Aug 5, 2024 •
edited
Loading

​DCMAW-9665

What changed

  • Set up pact tests with server for the /async/token endpoint
  • Add Pactfile with 400 and 200 status response interactions
  • Add configuration class for updating setting the state between interactions.

Why did it change

To enable contract testing between IPVCore and ID Check

Checklists

  • There is a ticket raised for this PR that is present in the branch name
  • No PII data logged. See guidance here
  • Demo to a BA, TA, and the team.
  • Update README with any new instructions or tasks

jmooney-dd and others added 30 commits August 1, 2024 11:48
@jmooney-dd
Install express and relevant types
2ec7193
@jmooney-dd
Create token handler and basic express app with route
84d2e70
@jhumbert-dd
DCMAW-9665: Install pact
0829b5b
@jhumbert-dd
DCMAW-9665: Add pact file
94530b6
@jhumbert-dd
DCMAW-9665: Format files
dbf377b
@jhumbert-dd
DCMAW-9665: Move pact file folder
80d1bad
@jhumbert-dd
DCMAW-9665: WIP - add pact test file
b2ee8f1
@jmooney-dd
Rename func
1a04db4
@jmooney-dd
Update pact file path in test
1c12c2c
@jmooney-dd
Create logging adapter properly
37a6dfd
@jmooney-dd
Removed /async/credential interactions from pact
0bc8f82
@jmooney-dd
Return status code of 200 as a start point
f768ac2
@jhumbert-dd
DCMAW-9665: Add script to run pact tests
086e56e
@jmooney-dd
Update req body to be url encoded in pact file
0e4ce5b
@jhumbert-dd
DCMAW-9665: WIP - update asyncTokenHandlerConstructor to handle reque…
75f9fae 
…st headers and body
@jhumbert-dd
DCMAW-9665: Add state configuration class
14b4203
@jhumbert-dd
DCMAW-9665: WIP - add state handler for invalid basic auth secret state
ab8ea41
@jmooney-dd
update bad secret response to 400 in pact file
87ae870
@jmooney-dd
Create dependencies in stateConfig class
62a13cd
@jmooney-dd
export mocked class
d3e4a40
@jmooney-dd
Use dependencies created in state handlers
e6c887e
@jmooney-dd
400 passing, 200 passing all but body key matchers
22d5ef2
@jmooney-dd
Remove type casting where not needed and console.log
5e304e4
@jmooney-dd
update mock value
363d923
@jmooney-dd
Remove more console.logs
2c11d19
@jmooney-dd
remove useless casting
c04777c
@jhumbert-dd
DCMAW-9665: Return parsed result body instead of full result
15fcdfe
@jmooney-dd
reset state dependencies before each test
b786bba
@jmooney-dd
Spelling mistake
6b816af
@jmooney-dd
create env in line when created token dependencies
3695e52
@J-son1 J-son1 requested review from a team as code owners August 5, 2024 14:02
jamesamooney
jamesamooney previously approved these changes Aug 5, 2024
View reviewed changes
@J-son1 J-son1 merged commit f62b741 into main Aug 5, 2024
1 check passed
@J-son1 J-son1 deleted the DCMAW-9665 branch August 5, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesamooney jamesamooney jamesamooney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@J-son1 @jamesamooney @jmooney-dd @jhumbert-dd