Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCMAW-9802: Refactor of Client Credential service #51

Merged
merged 19 commits into from
Jul 31, 2024

Conversation

sandy-may
Copy link
Contributor

@sandy-may sandy-may commented Jul 31, 2024

DCMAW-9802

What changed

Refactor of the client credential service:

  • Renamed to client registry service
  • Expose two public methods on the class for retrieving registered client details

Why did it change

  • There is data in the client registry that doesn't relate to client credentials
  • The lambdas had to orchestrate the service adding extra complexity to the lambda handler. This simplifies it so the lambda only knows what it needs to know to perform its job.

Checklists

  • There is a ticket raised for this PR that is present in the branch name
  • No PII data logged. See guidance here
  • Demo to a BA, TA, and the team.
  • Update README with any new instructions or tasks

@sandy-may sandy-may requested review from a team as code owners July 31, 2024 07:40
@sandy-may sandy-may changed the title Dcmaw 9802 credentialservice refactor DCMAW-9802: Refactor of Client Credential service Jul 31, 2024
@sandy-may sandy-may force-pushed the DCMAW-9802-credentialservice-refactor branch from f28a38b to 5cecd3d Compare July 31, 2024 10:20
@sandy-may sandy-may force-pushed the DCMAW-9802-credentialservice-refactor branch from 6cfbb7f to e5fe599 Compare July 31, 2024 10:22
@sandy-may sandy-may merged commit b14b9d2 into main Jul 31, 2024
1 check passed
@sandy-may sandy-may deleted the DCMAW-9802-credentialservice-refactor branch July 31, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants