Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCMAW-9802: Refactor session creation #44

Merged
merged 11 commits into from
Jul 25, 2024
Merged

DCMAW-9802: Refactor session creation #44

merged 11 commits into from
Jul 25, 2024

Conversation

J-son1
Copy link
Contributor

@J-son1 J-son1 commented Jul 25, 2024 •
edited
Loading

​DCMAW-9802

What changed

  • Refactors creating a session by moving logic to the Session Service to reduce the length of the /credential Lambda .

Checklists

  • There is a ticket raised for this PR that is present in the branch name
  • No PII data logged. See guidance here
  • Demo to a BA, TA, and the team.
  • Update README with any new instructions or tasks

@J-son1 J-son1 marked this pull request as ready for review July 25, 2024 11:01
@J-son1 J-son1 requested review from a team as code owners July 25, 2024 11:01
sandy-may
sandy-may previously approved these changes Jul 25, 2024
View reviewed changes
@J-son1 J-son1 merged commit 4ee7bf3 into main Jul 25, 2024
1 check passed
@J-son1 J-son1 deleted the DCMAW-9802-create-session-refactor branch July 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandy-may sandy-may sandy-may approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J-son1 @sandy-may @jhumbert-dd