DCMAW-11093: Update encryption algorithm for public encryption key #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandymay-dd
commented
Jan 17, 2025
sandymay-dd
changed the title
sandymay-dd
commented
Jan 20, 2025
sandymay-dd
commented
Jan 20, 2025
chris-cooksley-gds
previously approved these changes
Jan 20, 2025
sandymay-dd
commented
Jan 20, 2025
mthkbarber
previously approved these changes
Jan 20, 2025
sandymay-dd
dismissed stale reviews from mthkbarber and tmulberry-gds
via
456abfe
sandymay-dd
commented
Jan 20, 2025
sandymay-dd
requested review from
chris-cooksley-gds,
mthkbarber and
tmulberry-gds
chris-cooksley-gds
approved these changes
Jan 20, 2025
|
|
mthkbarber
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCMAW-11093
What changed
Change algorithm in the JSON web key object for the encryption key from
RS256toRSA-OAEP-256.Why did it change
To align with both the spec: https://datatracker.ietf.org/doc/html/rfc7518#section-4.1 (
RSA256is not a valid encryption algorithm) and the STS requirements: https://govukverify.atlassian.net/wiki/spaces/DCMAW/pages/3844964353/Strategic+App+App+calls+a+protected+service#Service-Token-encryptionChecklists