DCMAW-10784 - Spike Private DNS #293
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthkbarber
commented
Dec 11, 2024
backend-api/template.yaml
Outdated
| HostedZoneId: !ImportValue PublicHostedZoneId #Private hosted zone needed here | ||
| AliasTarget: | ||
| DNSName: !Sub ${PrivateApi}.execute-api.${AWS::Region}.amazonaws.com/${Environment} | ||
| HostedZoneId: !ImportValue PublicHostedZoneId #Private hosted zone needed here |
There was a problem hiding this comment.
336 and 338 need values for a private hosted zone, we currently only have a public hosted zone in our dns template.
mthkbarber
commented
Dec 11, 2024
| Type: AWS::ApiGateway::DomainNameV2 | ||
| Properties: | ||
| DomainName: !Sub | ||
| - private-${AWS::StackName}.${DNS_RECORD} |
There was a problem hiding this comment.
Domain name to be decided.
mthkbarber
commented
Dec 11, 2024
backend-api/template.yaml
Outdated
| DependsOn: PrivateApiDomainName | ||
| Properties: | ||
| DomainNameArn: !GetAtt PrivateApiDomainName.DomainNameArn | ||
| AccessAssociationSource: vpce-0825f978898f57283 |
There was a problem hiding this comment.
This is the VPC endpoint for the com.amazonaws.eu-west-2.execute-api service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCMAW-10784
Spike:
Attempt to apply a custom DNS to the Private API Gateway.
Resources successfully created:
Resource failing to create:
AWS::Route53::RecordSetCurrent error message