Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPS-1152: Add linting #588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

IPS-1152: Add linting #588

wants to merge 1 commit into from

Conversation

louiseli1
Copy link
Contributor

@louiseli1 louiseli1 commented Oct 7, 2024

What changed

  • Add linter
  • Edit template to fix following linting issues:
/Users/louiseli/GDS/ipv-cri-f2f-api/deploy % cfn-lint template.yaml                                                                                                        11:49:49
W3005 'F2FApiCustomDomainName' dependency already enforced by a 'Ref' at 'Resources/F2FApiBasePath/Properties/DomainName'
template.yaml:713:5

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:991:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:1024:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:2036:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:2098:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:2160:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:4736:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:4786:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:4836:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:4898:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:4960:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5022:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5084:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5146:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5208:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5270:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5332:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5394:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5456:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5518:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5580:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5642:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5704:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5766:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5828:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5893:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:5955:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:6020:7

E3020 'Dimensions' should not be included with 'Metrics'
template.yaml:6082:7

W6001 The output value {'Fn::ImportValue': {'Fn::Sub': '${IPVStubStackName}-IPVStubExecuteUrl'}} is an import from another output
template.yaml:7230:7

W6001 The output value {'Fn::ImportValue': {'Fn::Sub': '${L2DynamoStackName}-session-table-name'}} is an import from another output
template.yaml:7258:7

W6001 The output value {'Fn::ImportValue': {'Fn::Sub': '${L2DynamoStackName}-session-table-arn'}} is an import from another output
template.yaml:7264:7

W6001 The output value {'Fn::ImportValue': {'Fn::Sub': '${L2DynamoStackName}-session-table-key-arn'}} is an import from another output
template.yaml:7270:7

W6001 The output value {'Fn::ImportValue': {'Fn::Sub': '${L2DynamoStackName}-person-identity-table-name'}} is an import from another output
template.yaml:7276:7

W6001 The output value {'Fn::ImportValue': {'Fn::Sub': '${L2DynamoStackName}-person-identity-table-arn'}} is an import from another output
template.yaml:7282:7

W6001 The output value {'Fn::ImportValue': {'Fn::Sub': '${L2DynamoStackName}-person-identity-table-key-arn'}} is an import from another output
template.yaml:7288:7

W6001 The output value {'Fn::ImportValue': {'Fn::Sub': '${L2KMSStackName}-vc-signing-key-id'}} is an import from another output
template.yaml:7311:7

Why did it change

  • Code quality control

Issue tracking

Checklists

PII logging

  • Verified that no PII data is being logged

Environment variables or secrets

  • No environment variables or secrets were added or changed
  • Documented in the README
  • Added to deployment repository
  • Added to local startup repository

Other considerations

  • Update README with any new instructions or tasks

@louiseli1 louiseli1 marked this pull request as ready for review October 9, 2024 12:38
@louiseli1 louiseli1 requested review from a team as code owners October 9, 2024 12:38
Copy link

Copy link

sonarqubecloud bot commented Jan 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant