fix(dfc-717): add data attributes for navigation tracking

govuk-one-login · Jan 17, 2025 · cb0918c · cb0918c
1 parent db99835
commit cb0918c
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 10 deletions.
diff --git a/src/views/address/address.njk b/src/views/address/address.njk
@@ -23,7 +23,7 @@
     {% include "../components/address-input-fields.njk" %}
     {{ yearFromField(ctx, { name: "addressYearFrom", title: title, label: label }) }}
 
-    {{ hmpoSubmit(ctx, {id: "continue", text: translate("buttons.next")}) }}
+    {{ hmpoSubmit(ctx, {attributes: {"data-nav": "true", "data-link": "/undefined"}, id: "continue", text: translate("buttons.next")}) }}
 
   {% endcall %}
 

diff --git a/src/views/address/results.njk b/src/views/address/results.njk
@@ -24,7 +24,7 @@
 
     {{ hmpoHtml(translate("links.cantFindAddress")) }}
 
-    {{ hmpoSubmit(ctx, {id: "continue", text: translate("buttons.select-address")}) }}
+    {{ hmpoSubmit(ctx, {id: "continue", attributes: {"data-nav": true, "data-link": "/undefined"}, text: translate("buttons.select-address")}) }}
 
   {% endcall %}
 

diff --git a/src/views/address/search.njk b/src/views/address/search.njk
@@ -32,7 +32,10 @@
       autocomplete: "postal-code"
     }) }}
 
-    {{ hmpoSubmit(ctx, {id: "continue", text: translate("buttons.find-address")}) }}
+    {{ hmpoSubmit(ctx, {
+      id: "continue",
+      attributes: { "data-nav": true, "data-link": "/results" }, 
+      text: translate("buttons.find-address")}) }}
     {%- include "../components/continue-submit-spinner.njk" -%}
 
   {% endcall %}

diff --git a/src/views/components/address-confirm.njk b/src/views/components/address-confirm.njk
@@ -151,9 +151,11 @@
         text: translate("pages.address-confirm.buttons.next"),
         id: "continue",
         attributes: {
-        "data-id": "next"
-      }
-    }) }}
+        "data-id": "next",
+        "data-nav": true,
+        "data-link": "/undefined"
+        }
+      }) }}
     {%- include "../components/continue-submit-spinner.njk" -%}
 
   {% endcall %}

diff --git a/src/views/components/address-problem-field.njk b/src/views/components/address-problem-field.njk
@@ -19,7 +19,7 @@
     })
   }}
 
-  {{ hmpoSubmit(ctx, {id: "continue", text: translate("buttons.next")}) }}
+  {{ hmpoSubmit(ctx, {attributes: {"data-nav": true, "data-link": "/undefined"}, id: "continue", text: translate("buttons.next")}) }}
 
  {{hmpoHtml(translate("links.helpContact"))}}
 

diff --git a/src/views/previous/address.njk b/src/views/previous/address.njk
@@ -17,7 +17,7 @@
 
     {% include "../components/address-input-fields.njk" %}
 
-    {{ hmpoSubmit(ctx, {id: "continue", text: translate("buttons.next")}) }}
+    {{ hmpoSubmit(ctx, {attributes: {"data-nav": true, "data-link": "/undefined"}, id: "continue", text: translate("buttons.next")}) }}
 
   {% endcall %}
   {{ ga4OnPageLoad({

diff --git a/src/views/previous/results.njk b/src/views/previous/results.njk
@@ -25,7 +25,7 @@
 
     {{ hmpoHtml(translate("links.previous.cantFindAddress")) }}
 
-    {{ hmpoSubmit(ctx, {id: "continue", text: translate("buttons.select-address")}) }}
+    {{ hmpoSubmit(ctx, {attributes: {"data-nav": true, "data-link": "/previous-address-check"}, id: "continue", text: translate("buttons.select-address")}) }}
 
   {% endcall %}
 

diff --git a/src/views/previous/search.njk b/src/views/previous/search.njk
@@ -22,7 +22,7 @@
       hint:  translate("fields.addressSearch.previous.hint")
     }) }}
 
-    {{ hmpoSubmit(ctx, {id:"continue", text: translate("buttons.find-address")}) }}
+    {{ hmpoSubmit(ctx, {id:"continue", attributes: {"data-nav": true, "data-link": "/previous-results"}, text: translate("buttons.find-address")}) }}
 
   {% endcall %}
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,7 @@ @@
         })
       }}
-      {{ hmpoSubmit(ctx, {id: "continue", text: translate("buttons.next")}) }}
+      {{ hmpoSubmit(ctx, {attributes: {"data-nav": true, "data-link": "/undefined"}, id: "continue", text: translate("buttons.next")}) }}
      {{hmpoHtml(translate("links.helpContact"))}}
@@ Expand Down @@