PYIC-7484: add functional tests for mobile download link #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thebauSoftwire
commented
Feb 4, 2025
Comment on lines
+39
to
+43
| const responsePromise = page.waitForResponse(response => response.status() == 301); | ||
| await page.getByRole('button', {name: "Download GOV.UK One Login"}).click(); | ||
| const response = await responsePromise; | ||
|
|
||
| expect(response.headers()['location']).toMatch(/^.*apps\.apple\.com\/gb\/app\/gov-uk-id-check.*$/); |
There was a problem hiding this comment.
this is handled differently for apple devices as instead of going straight to the page, it will try and open it in the app for the app store instead so page.url will remain as .../pyi-triage-mobile-download-app/en?context=iphone but checking that the 301 redirect response will have location itms-appss:appls.apple.com/... in its headers instead
|
I'm not sure why the pyi-triage-desktop-download-app screenshots have been marked as needing an update. I've ran the browser tests multiple times and have required the same change so I don't think it's flakiness... 🤔 |
thebauSoftwire
force-pushed
the
pyic-7484
branch
from
a53f01d to
0bf1b35
Compare
|
blakeyp
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Added functional tests for handling mobile download link
Why did it change
Increase test coverage
Issue tracking