BAU: missing ip address from process-candidate-identity and check-coi lambdas #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shivanshuit914
approved these changes
Jan 29, 2025
thebauSoftwire
deleted the
bau-process-candidate-identity-missing-ip-address-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Add ip address as input to process-candidate-identity and check-coi lambdas.
Audit events emitted as part of the process-candidate-identity lambda now have non-null ip addresses.
Audit events emitted as part of the check-coi lambda now have non-null ip addresses.
Why did it change
We weren't passing in the ip address as an input to either of the lambdas although both use the ip address for things like audit events. This means that the ip_address in the audit events have been null.