Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYIC-7968: Update API tests and local running to enable DL auth check #2910

Merged
merged 3 commits into from
Jan 24, 2025
Merged

PYIC-7968: Update API tests and local running to enable DL auth check #2910

merged 3 commits into from
Jan 24, 2025

Conversation

DanCorderIPV
Copy link
Contributor

@DanCorderIPV DanCorderIPV commented Jan 24, 2025 •
edited by jira bot
Loading

Proposed changes

What changed

Update local running and fix API tests for DL auth check

Why did it change

We're turning on DL auth check

Issue tracking

@DanCorderIPV DanCorderIPV requested review from a team as code owners January 24, 2025 12:21
MikeCollingwood
MikeCollingwood previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@MikeCollingwood MikeCollingwood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I had a brief look into doing this myself and this is what I was expecting. Just a minor naming comment

api-tests/features/p2-web-journey.feature Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DanCorderIPV DanCorderIPV merged commit 51370c4 into main Jan 24, 2025
7 checks passed
@DanCorderIPV DanCorderIPV deleted the PYIC-7968-update-API-tests-for-DL-auth-check branch January 24, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeCollingwood MikeCollingwood MikeCollingwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanCorderIPV @MikeCollingwood