-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYIC-7832: Update journey map with new page #2854
base: main
Are you sure you want to change the base?
Conversation
@@ -328,25 +328,10 @@ states: | |||
f2f: | |||
targetJourney: F2F_HAND_OFF | |||
targetState: START | |||
|
|||
PYI_CRI_ESCAPE_NO_F2F: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For P2 we should probably keep the old states initially (and remove in a follow-up PR) to stage this out in case there any in flight journeys in these states as the deploy goes through
checkIfDisabled: | ||
f2f: | ||
targetState: PYI_CRI_ESCAPE_NO_F2F | ||
end: | ||
targetState: PYI_KBV_DROPOUT_NO_PHOTO_ID | ||
checkIfDisabled: | ||
f2f: | ||
targetState: PYI_CRI_ESCAPE_NO_F2F | ||
next: | ||
targetJourney: EVALUATE_SCORES | ||
targetState: START | ||
enhanced-verification: | ||
targetState: MITIGATION_KBV_FAIL_NO_PHOTO_ID | ||
checkIfDisabled: | ||
f2f: | ||
targetState: MITIGATION_02_OPTIONS | ||
auditEvents: | ||
- IPV_MITIGATION_START | ||
auditContext: | ||
mitigationType: enhanced-verification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably not explicit in the ticket sorry, but as we're doing this could we also handle f2f
disabled in PYI_KBV_DROPOUT_NO_PHOTO_ID
and MITIGATION_KBV_FAIL_NO_PHOTO_ID
same as photo id?
next: | ||
targetJourney: EVALUATE_SCORES | ||
targetState: START | ||
enhanced-verification: | ||
targetState: MITIGATION_02_OPTIONS_WITH_F2F | ||
targetState: PYI_KBV_DROPOUT_PHOTO_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm don't we still need a separate state for this, as the page will be context dependent - like PYI_KBV_DROPOUT_NO_PHOTO_ID
and MITIGATION_KBV_FAIL_NO_PHOTO_ID
for no photo id?
pyi-cri-escape and pyi-suggest-other-options templates will now be combined into a single dynamic template with URL photo-id-security-questions-find-another-way This also remove the no-F2F versions of this page and route to error in the case F2F is disabled
30a281e
to
214a414
Compare
Keep original states for now so it does not break any exisiting journeys, will be removed in follow up PR We need to version of the new route, one with the context dropout
Quality Gate passedIssues Measures |
Proposed changes
What changed
pyi-cri-escape and pyi-suggest-other-options templates will now be combined into a single dynamic template with URL
photo-id-security-questions-find-another-way This also remove the no-F2F versions of this page and route to error in the case F2F is disabled
Why did it change
Issue tracking
Checklists
Environment variables or secrets