Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYIC-6242: Add ProcessMobileAppCallbackHandler #2615

Merged
merged 15 commits into from
Oct 30, 2024
Merged

PYIC-6242: Add ProcessMobileAppCallbackHandler #2615

merged 15 commits into from
Oct 30, 2024

Conversation

MikeCollingwood
Copy link
Contributor

@MikeCollingwood MikeCollingwood commented Oct 22, 2024 •
edited
Loading

Proposed changes

What changed

  • Add ProcessMobileAppCallbackHandler
  • Add event mapping and state for successful progression from the download page
  • Refactor CriResponse fetching logic
  • Update ProcessStepResponse to allow for context
  • Use mam/ dad lambdaInput attribute to condition clientCallbackUrl inclusion

Why did it change

  • Allow users to callback from dcmaw async

Issue tracking

@MikeCollingwood MikeCollingwood requested review from a team as code owners October 22, 2024 13:54
@MikeCollingwood MikeCollingwood marked this pull request as draft October 22, 2024 13:54
@MikeCollingwood
PYIC-6242: Add context-based nullifying of client callback url for ca…
d2e010f 
…ll async dcmaw
@MikeCollingwood
PYIC-6242: Update mobile app callback parseCallbackRequest method
f763b76
@MikeCollingwood
PYIC-6242: Update tests affected by mobile app callback parseCallback…
8bced78 
…Request method
@MikeCollingwood
PYIC-6242: Add new lambda to local-running
b8c89bc
@MikeCollingwood
PYIC-6242: Add context to ProcessStepResponse class
2520982
@MikeCollingwood
PYIC-6242: Add tests to RequestHelperTest and remove unused variable
debbbf7
@MikeCollingwood
PYIC-6242: Add wildcard reference to /journey/call-dcmaw-async-cri st…
80887f5 
…ep function choice match
@MikeCollingwood
PYIC-6242: Add journey param to CallDcmawAsyncCriLambda input
9ce0310
@MikeCollingwood
PYIC-6242: Add dynamoDb KMSDecryptPolicy policy to ProcessMobileAppCa…
019fd8a 
…llbackFunction cloudformation config
@MikeCollingwood
PYIC-6242: Fix local running journeyStep choice match for uri with co…
26a58a3 
…ntext for dcmaw async
@MikeCollingwood MikeCollingwood marked this pull request as ready for review October 24, 2024 13:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MikeCollingwood MikeCollingwood merged commit a1cfbb3 into main Oct 30, 2024
9 checks passed
@MikeCollingwood MikeCollingwood deleted the pyic-6242 branch October 30, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeyp blakeyp blakeyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeCollingwood @blakeyp