PYIC-5872: Open dev internal api gateway again #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1143d1c.
Having conditional events on functions wasn't working in non dev environments. It appears CloudFormation wanted to resolve the nested reference to the conditionally created API gateway before noticing that the event itself didn't need creating. This led to errors due to an unresolveable reference. Having inspected the CloudFormation stacks created with and without the event, the only extra resource being created was the permission on the lambda to allow the testing API gateway to invoke it. All the other API gateway resources that it might create were already handled by using the OpenApi spec when creating the gateway itself. We can create that permission separately and use a conditional for it.
Wynndow
force-pushed
the
pyic-5872-open-internal-api-gateway-again
branch
from
cf1ef54 to
cc44783
Compare
|
| RestApiId: !Ref IPVCorePrivateAPI | ||
| Path: /journey/{journeyStep+} | ||
| Method: POST | ||
| IPVCoreInternalTestingApi: |
There was a problem hiding this comment.
Should this one still be here?
There was a problem hiding this comment.
Yep - this approach works when attaching to a step function, rather than a lambda function. Thanks CloudFormation.
Yeah - i've intentionally put the new permissions with the functions rather than all grouped with the new gateway. I'm guessing that the next time we add an internal function we'll look at prior art and it'll help future us remember. |
Joe-Edwards-GDS
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Open dev internal api gateway again.
I've tested that this will actually deploy to a non-dev environment.
Why did it change
Revert "Revert "PYIC-5872: Open API gateway""
This reverts commit 1143d1c.
This reversion commit was for everthing in #1966.
Reverting the reversion to bring the changes back in, and then roll forward in the next commit.
PYIC-5872: Use lambda perm over conditional event
Having conditional events on functions wasn't working in non dev
environments. It appears CloudFormation wanted to resolve the nested
reference to the conditionally created API gateway before noticing that
the event itself didn't need creating. This led to errors due to an
unresolveable reference.
Having inspected the CloudFormation stacks created with and without the
event, the only extra resource being created was the permission on the
lambda to allow the testing API gateway to invoke it. All the other API
gateway resources that it might create were already handled by using the
OpenApi spec when creating the gateway itself.
We can create that permission separately and use a conditional for it.
Issue tracking