Merge pull request #1924 from govuk-one-login/bau-use-failed-confirm-…

…details-error-page BAU: Use correct failure page for COI and 6MFC journeys
govuk-one-login · May 16, 2024 · 706eb2d · 706eb2d
2 parents f2efc82 + cd35a9d
commit 706eb2d
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 86 deletions.
diff --git a/lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml b/lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml
@@ -16,7 +16,7 @@ states:
           ticfCriBeta:
             targetState: CRI_TICF_BEFORE_NO_MATCH
 
-  FAILED_COI:
+  FAILED_CONFIRM_DETAILS:
     events:
       next:
         targetState: COULD_NOT_CONFIRM_DETAILS_PAGE
@@ -45,44 +45,8 @@ states:
       next:
         targetState: NO_MATCH_PAGE
 
-  FAILED_RFC:
-    events:
-      next:
-        targetState: NO_MATCH_PAGE_RFC
-        checkFeatureFlag:
-          ticfCriBeta:
-            targetState: CRI_TICF_BEFORE_NO_MATCH_PAGE_RFC
-
-  FAILED_UPDATE_ADDRESS:
-    events:
-      next:
-        # same page as RFC displayed so re-use this state
-        targetState: NO_MATCH_PAGE_RFC
-        checkFeatureFlag:
-          ticfCriBeta:
-            targetState: CRI_TICF_BEFORE_NO_MATCH_PAGE_RFC
-
   # Journey states
 
-  CRI_TICF_BEFORE_NO_MATCH_PAGE_RFC:
-    response:
-      type: process
-      lambda: call-ticf-cri
-    events:
-      next:
-        targetState: NO_MATCH_PAGE_RFC
-      enhanced-verification:
-        targetState: NO_MATCH_PAGE_RFC
-      alternate-doc-invalid-dl:
-        targetState: NO_MATCH_PAGE_RFC
-      alternate-doc-invalid-passport:
-        targetState: NO_MATCH_PAGE_RFC
-      fail-with-ci:
-        targetState: NO_MATCH_PAGE_RFC
-      error:
-        targetJourney: TECHNICAL_ERROR
-        targetState: ERROR_NO_TICF
-
   CRI_TICF_BEFORE_NO_MATCH:
     response:
       type: process
@@ -175,15 +139,6 @@ states:
       next:
         targetState: RETURN_TO_RP
 
-  NO_MATCH_PAGE_RFC:
-    response:
-      type: page
-      pageId: pyi-no-match
-      context: repeatFraudCheck
-    events:
-      next:
-        targetState: RETURN_TO_RP
-
   NO_MATCH_PAGE_BAV:
     response:
       type: page

diff --git a/...rocess-journey-event/src/main/resources/statemachine/journey-maps/repeat-fraud-check.yaml b/...rocess-journey-event/src/main/resources/statemachine/journey-maps/repeat-fraud-check.yaml
@@ -17,31 +17,31 @@ states:
     events:
       not-found:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
       fail-with-no-ci:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
       error:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
       access-denied:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
       enhanced-verification:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
       temporarily-unavailable:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
       fail-with-ci:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
       vcs-not-correlated:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
       alternate-doc-invalid-dl:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
 
   # Journey States
 
@@ -85,7 +85,7 @@ states:
         targetState: EVALUATE_GPG45_SCORES_RFC
       enhanced-verification:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
 
   ADDRESS_AND_FRAUD_RFC:
     nestedJourney: ADDRESS_AND_FRAUD
@@ -94,7 +94,7 @@ states:
         targetState: EVALUATE_GPG45_SCORES_RFC
       enhanced-verification:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
 
   EVALUATE_GPG45_SCORES_RFC:
     response:
@@ -108,10 +108,10 @@ states:
             targetState: CRI_TICF_BEFORE_SUCCESS_RFC
       unmet:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
       vcs-not-correlated:
         targetJourney: FAILED
-        targetState: FAILED_RFC
+        targetState: FAILED_CONFIRM_DETAILS
 
   STORE_IDENTITY_BEFORE_SUCCESS:
     response:

diff --git a/...as/process-journey-event/src/main/resources/statemachine/journey-maps/update-address.yaml b/...as/process-journey-event/src/main/resources/statemachine/journey-maps/update-address.yaml
@@ -17,31 +17,31 @@ states:
     events:
       not-found:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
       fail-with-no-ci:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
       error:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
       access-denied:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
       enhanced-verification:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
       temporarily-unavailable:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
       fail-with-ci:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
       vcs-not-correlated:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
       alternate-doc-invalid-dl:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
 
   # Journey States
 
@@ -60,7 +60,7 @@ states:
         targetState: CHECK_COI_UPDATE_ADDRESS
       enhanced-verification:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
 
   CHECK_COI_UPDATE_ADDRESS:
     response:
@@ -71,7 +71,7 @@ states:
         targetState: EVALUATE_GPG45_SCORES_UPDATE_ADDRESS
       coi-check-failed:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       error:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
@@ -88,10 +88,10 @@ states:
             targetState: CRI_TICF_BEFORE_SUCCESS_UPDATE_ADDRESS
       unmet:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
       vcs-not-correlated:
         targetJourney: FAILED
-        targetState: FAILED_UPDATE_ADDRESS
+        targetState: FAILED_CONFIRM_DETAILS
 
   STORE_IDENTITY_BEFORE_SUCCESS:
     response:

diff --git a/lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/update-name.yaml b/lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/update-name.yaml
@@ -23,31 +23,31 @@ states:
     events:
       not-found:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       fail-with-no-ci:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       error:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
       access-denied:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       enhanced-verification:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       temporarily-unavailable:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
       fail-with-ci:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       vcs-not-correlated:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       alternate-doc-invalid-dl:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
 
   # Journey States
 
@@ -84,16 +84,16 @@ states:
         targetState: POST_DCMAW_SUCCESS_PAGE_NAME_ONLY
       not-found:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       access-denied:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       temporarily-unavailable:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
       fail-with-no-ci:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
 
   POST_DCMAW_SUCCESS_PAGE_NAME_ONLY:
     response:
@@ -114,7 +114,7 @@ states:
         targetState: CHECK_COI_UPDATE_NAME
       enhanced-verification:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
 
   # WITH ADDRESS
 
@@ -149,16 +149,16 @@ states:
         targetState: POST_DCMAW_SUCCESS_PAGE_NAME_ADDRESS
       not-found:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       access-denied:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       temporarily-unavailable:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
       fail-with-no-ci:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
 
   POST_DCMAW_SUCCESS_PAGE_NAME_ADDRESS:
     response:
@@ -176,7 +176,7 @@ states:
         targetState: CHECK_COI_UPDATE_NAME
       enhanced-verification:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
 
   # SHARED STATES
 
@@ -189,7 +189,7 @@ states:
         targetState: EVALUATE_GPG45_SCORES_UPDATE_NAME
       coi-check-failed:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       error:
         targetJourney: TECHNICAL_ERROR
         targetState: ERROR
@@ -206,10 +206,10 @@ states:
             targetState: CRI_TICF_BEFORE_SUCCESS_UPDATE_ADDRESS
       unmet:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
       vcs-not-correlated:
         targetJourney: FAILED
-        targetState: FAILED_COI
+        targetState: FAILED_CONFIRM_DETAILS
 
   STORE_IDENTITY_BEFORE_SUCCESS_UPDATE_NAME:
     response: