Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATO-1144: Add infrastructure for new IPV JWKS endpoint #5772

Merged
merged 2 commits into from
Jan 21, 2025
Merged

ATO-1144: Add infrastructure for new IPV JWKS endpoint #5772

merged 2 commits into from
Jan 21, 2025

Conversation

cearl1
Copy link
Contributor

@cearl1 cearl1 commented Jan 17, 2025 •
edited
Loading

What’s changed

Added a new lambda to be used for hosting IPV JWKs.

Manual testing

Tested in sandpit, can hit the new orch lambda at /.well-known/ipv-jwks.json

Checklist

  • Impact on orch and auth mutual dependencies has been checked.
  • Changes have been made to contract tests or not required.
  • Changes have been made to the simulator or not required.
  • Changes have been made to stubs or not required.
  • Successfully deployed to authdev or not required.
  • Successfully run Authentication acceptance tests against sandpit or not required.

@cearl1 cearl1 force-pushed the ATO-1144/publish-jwks-endpoint-for-ipv-infra branch 5 times, most recently from fd0f9b3 to 4a6f532 Compare January 17, 2025 12:31
CarlyG55
CarlyG55 reviewed Jan 17, 2025
View reviewed changes
ci/terraform/oidc/ipv-jwks.tf Outdated Show resolved Hide resolved
oidc-api/src/main/java/uk/gov/di/authentication/oidc/lambda/IpvJwksHandler.java Outdated Show resolved Hide resolved
template.yaml Outdated Show resolved Hide resolved
template.yaml Outdated Show resolved Hide resolved
@cearl1 cearl1 force-pushed the ATO-1144/publish-jwks-endpoint-for-ipv-infra branch from 4a6f532 to 0ca1ccf Compare January 17, 2025 14:08
@cearl1 cearl1 force-pushed the ATO-1144/publish-jwks-endpoint-for-ipv-infra branch from 0ca1ccf to f3a1845 Compare January 17, 2025 15:41
@cearl1 cearl1 marked this pull request as ready for review January 17, 2025 15:41
@cearl1 cearl1 requested review from a team as code owners January 17, 2025 15:41
@cearl1 cearl1 force-pushed the ATO-1144/publish-jwks-endpoint-for-ipv-infra branch from f3a1845 to 5397bd7 Compare January 17, 2025 15:52
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 17, 2025
View reviewed changes
ci/terraform/oidc/api-gateway.tf Dismissed Show dismissed Hide dismissed
@cearl1 cearl1 force-pushed the ATO-1144/publish-jwks-endpoint-for-ipv-infra branch from 5397bd7 to c630eee Compare January 17, 2025 16:14
CarlyG55
CarlyG55 requested changes Jan 17, 2025
View reviewed changes
ci/terraform/oidc/dev.tfvars Outdated Show resolved Hide resolved
@cearl1 cearl1 force-pushed the ATO-1144/publish-jwks-endpoint-for-ipv-infra branch from c630eee to 3ddb1af Compare January 20, 2025 08:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cearl1 cearl1 added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 54a7c3a Jan 21, 2025
22 checks passed
@cearl1 cearl1 deleted the ATO-1144/publish-jwks-endpoint-for-ipv-infra branch January 21, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlyG55 CarlyG55 CarlyG55 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cearl1 @CarlyG55