forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LC PUId #1
Open
hqucms
wants to merge
10
commits into
gouskos:hgcal_pu
Choose a base branch
from
hqucms:dev/hgcal/pu_per_lc
base: hgcal_pu
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LC PUId #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouskos
pushed a commit
that referenced
this pull request
Oct 16, 2020
Copy EcalDeadChannelRecoveryBDTG.* from master and fix ecalRecHit_cfi…
gouskos
pushed a commit
that referenced
this pull request
Dec 3, 2020
…rebase Use special workflow instead of Era
gouskos
pushed a commit
that referenced
this pull request
Dec 3, 2020
Scouting muon producer and class update
gouskos
pushed a commit
that referenced
this pull request
Feb 10, 2021
aestethic stuff This is the commit message #1.3: seedingDeepCore modifier This is the commit message #1.4: cleaning DeepCore plugin code This is the commit message #1.5: deepCore module by modifier This is the commit message #1.6: some small fix This is the commit message #1.7: buildfile3 fix auto parameters code format fix validation on relvant eras only, some fix fix eras bug additional plots for Run3 only move to existising object in _cff, cleaning of DeepCore cleaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the code is working now. The output is also consistent with the training code. I think we can move on and run more tests:)
There are two testing/validation cfgs that you can start with:
RecoHGCal/TICL/test/test_lc_puid_cfg.py
runs only the lcPUWeights and print out the inputs/outputsRecoHGCal/TICL/test/test_ticl_with_lc_puid_cfg.py
runs the lcPUWeights and TICL, using only LCs w/ wgt>0.2.