Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for site_name #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/link_thumbnailer/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def initialize
%r{^http://pixel\.quantserve\.com/},
%r{^http://s7\.addthis\.com/}
]
@attributes = [:title, :images, :description, :videos, :favicon, :body]
@attributes = [:title, :images, :description, :videos, :favicon, :body, :site_name]
@graders = [
->(description) { ::LinkThumbnailer::Graders::Length.new(description) },
->(description) { ::LinkThumbnailer::Graders::HtmlAttribute.new(description, :class) },
Expand Down
20 changes: 20 additions & 0 deletions lib/link_thumbnailer/models/site_name.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# frozen_string_literal: true

require 'link_thumbnailer/model'

module LinkThumbnailer
module Models
class SiteName < ::LinkThumbnailer::Model
attr_reader :node, :text

def initialize(node, text = nil)
@node = node
@text = sanitize(text || node.text)
end

def to_s
text
end
end
end
end
3 changes: 2 additions & 1 deletion lib/link_thumbnailer/models/website.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module LinkThumbnailer
module Models
class Website < ::LinkThumbnailer::Model

attr_accessor :url, :title, :description, :images, :videos, :favicon, :body
attr_accessor :url, :title, :description, :images, :videos, :favicon, :body, :site_name

def initialize
@images = []
Expand Down Expand Up @@ -42,6 +42,7 @@ def as_json(*)
{
url: url.to_s,
favicon: favicon,
site_name: site_name,
title: title,
description: description,
images: images.map(&:as_json),
Expand Down
2 changes: 2 additions & 0 deletions lib/link_thumbnailer/scraper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
require 'link_thumbnailer/scrapers/opengraph/favicon'
require 'link_thumbnailer/scrapers/default/body'
require 'link_thumbnailer/scrapers/opengraph/body'
require 'link_thumbnailer/scrapers/default/site_name'
require 'link_thumbnailer/scrapers/opengraph/site_name'

module LinkThumbnailer
class Scraper < ::SimpleDelegator
Expand Down
16 changes: 16 additions & 0 deletions lib/link_thumbnailer/scrapers/default/site_name.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# frozen_string_literal: true

require 'link_thumbnailer/scrapers/default/base'
require 'link_thumbnailer/models/site_name'

module LinkThumbnailer
module Scrapers
module Default
class SiteName < ::LinkThumbnailer::Scrapers::Default::Base
def value
nil
end
end
end
end
end
12 changes: 12 additions & 0 deletions lib/link_thumbnailer/scrapers/opengraph/site_name.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# frozen_string_literal: true

require 'link_thumbnailer/scrapers/opengraph/base'

module LinkThumbnailer
module Scrapers
module Opengraph
class SiteName < ::LinkThumbnailer::Scrapers::Opengraph::Base
end
end
end
end