Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eve-scout: fix thera routes (#221) #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duaneg
Copy link

@duaneg duaneg commented Jul 25, 2024

It appears the data returned from the code that mediates access to the EVE Scout Thera connections data is now returning an array instead of an object.

Update the code to retrieve the contents accordingly. Also correctly initialise the empty jump nodes list when creating a new system entry.

It appears the data returned from the code that mediates access to the
EVE Scout Thera connections data is now returning an array instead of an
object.

Update the code to retrieve the contents accordingly. Also correctly
initialise the empty jump nodes list when creating a new system entry.
@duaneg
Copy link
Author

duaneg commented Jul 25, 2024

Note that this might be better fixed by changing the returned data type back to an object in pathfinder_esi, but there were a few other little issues that needed fixing in the pathfinder code also (see patch for details), and figuring out how to get PF working with a local dev version of pathfinder_esi was another hoop to jump, so here we go ;-)

@fleischsalatinspace
Copy link
Collaborator

Hello @duaneg , sorry for the lack of response. Vacation time 🌴 .

I have not tried the code yet, but does this pr fix the issue with the missing thera route?

fly safe o7

@duaneg
Copy link
Author

duaneg commented Aug 25, 2024

No problem at all, I hope your vacation was a pleasant one!

Yes, this fixes the issue, at least to the extent of my testing locally. FYI, I have a half-completed patch which also adds Turnur routes. If you folks would be interested in merging it, I'll try and polish it up and finish it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants