S24 privacy combined profile #1060
Conversation
…rder to solve merging conflicts
This reverts commit a937cfd.
Generalized user privacy variable names and defined values for isPrivate to be PUBLIC or PRIVATE rather than False or True in Combined Profile View Model
| @@ -635,7 +635,11 @@ private async Task<bool> CanUpdateAsync(string resource) | |||
|
|
|||
| return false; | |||
| } | |||
|
|
|||
| case Resource.PROFILE_PRIVACY: | |||
There was a problem hiding this comment.
Is this used? Should it be?
(Is it only supported for facstaff?)
There was a problem hiding this comment.
The new privacy settings now are available to all users, but the call to StateYourBusiness() in the ProfileController is commented out and that is the only place this resource is used. One way to address this would be to uncomment the StateYourBusiness() reference but have it just return true for all users rather than returning true only for facstaff.
There was a problem hiding this comment.
Now the profile controller does call StateYourBusiness() with the PROFILE_PRIVACY resource. SYB() always returns true, so behavior is not changed but this makes it easier to add some restrictions if needed in the future.
|
|
||
| namespace Gordon360.Models.ViewModels | ||
| { | ||
| // Field: the field where the user wants to update the privacy setting (HomeCity, HomeState, HomeCountry, SpouseName, Country, HomePhone, MobilePhone) |
There was a problem hiding this comment.
| // Field: the field where the user wants to update the privacy setting (HomeCity, HomeState, HomeCountry, SpouseName, Country, HomePhone, MobilePhone) | |
| // Field: a list of fields where the user wants to update the privacy setting (HomeCity, HomeState, HomeCountry, SpouseName, Country, HomePhone, MobilePhone) |
There was a problem hiding this comment.
No, I think field is a single instance of one of the values listed in the comment.
There was a problem hiding this comment.
On second look, at least one place a comment like this occurs it does seem that Field is a list -- I'll fix the comment.
| // Field: the field where the user selected the privacy setting | ||
| // (HomeCity, HomeState, HomeCountry, SpouseName, Country, HomePhone, MobilePhone) | ||
| // VisibilityGroup: the group that the user wanted to be seen by (Public, Private, FacStaff) | ||
| public class UserPrivacyViewModel |
There was a problem hiding this comment.
I'm a little confused by the difference between 3 very similar UserPrivacy*ViewModel s. Maybe it's just me, but could we make the comments a little clearer about the role and purpose of each one?
|
|
||
| namespace Gordon360.Models.ViewModels | ||
| { | ||
| // Field: the field where the user wants to update the privacy setting (HomeCity, HomeState, HomeCountry, SpouseName, Country, HomePhone, MobilePhone) |
There was a problem hiding this comment.
Let's add an overall comment about the purpose of this class. So far, I see that it's used as an argument to UpdateUserPrivacyAsync in ProfileService.cs.
Fixed typo Co-authored-by: Russ Tuck <[email protected]>
Co-authored-by: Russ Tuck <[email protected]>
Co-authored-by: Russ Tuck <[email protected]>
Generalize privacy settings for items appearing in a user's profile.
This is a large PR and reflects work done during two consecutive summer practicums. It supersedes PR #1042 and #937 and is partnered with PR gordon-cs/gordon-360-ui#2355 in gordon-360-ui.
See gordon-cs/gordon-360-ui#2355 for a description.