Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S24 Posters #1055

Open
wants to merge 42 commits into
base: develop
Choose a base branch
from
Open

S24 Posters #1055

wants to merge 42 commits into from

Conversation

amos-cha
Copy link
Contributor

No description provided.

@amos-cha amos-cha added Feature A new feature s24 Summer Practicum 2024 labels Jun 24, 2024
@amos-cha amos-cha marked this pull request as draft June 24, 2024 14:10
Gordon360/Properties/launchSettings.json Outdated Show resolved Hide resolved
Gordon360/Properties/launchSettings.json Outdated Show resolved Hide resolved
Gordon360/appsettings.json Outdated Show resolved Hide resolved
@@ -611,7 +629,6 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
});
modelBuilder.HasSequence("Information_Change_Request_Seq");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OnModelCreatingGeneratedProcedures(modelBuilder);

@CollyWills16670 CollyWills16670 marked this pull request as ready for review September 12, 2024 21:22
.gitignore Outdated
Gordon360/Logs/*
/Gordon360/Controllers/HomeController.cs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line here? I suspect it shouldn't be.

@bennettforkner
Copy link
Contributor

@amos-cha could you add a description to the top of this, especially as you are adding a new feature. I'm not sure I understand what a poster is after reading the code.

@amos-cha
Copy link
Contributor Author

amos-cha commented Sep 27, 2024

@bennettforkner this is a question for @CollyWills16670

I only helped do setup and don't remember too much about this

@CollyWills16670
Copy link

@amos-cha could you add a description to the top of this, especially as you are adding a new feature. I'm not sure I understand what a poster is after reading the code.

I do not know if this answers your question, but the point of this is to allow club leaders to upload images of posters for their events that will appear in a new carousel on the UI side. It will allow students to view posters for their own involvements, and explore some from the rest of the campus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature s24 Summer Practicum 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants