Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

Add leader change event for followers #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

palquel
Copy link

@palquel palquel commented Aug 6, 2014

@philips
Copy link
Member

philips commented Aug 6, 2014

This LGTM. However, does it also fix thos "empty" messages as reported in etcd-io/etcd#913?

Any objections @benbjohnson @xiangli-cmu ?

@palquel
Copy link
Author

palquel commented Aug 6, 2014

@philips using the etcd-io/etcd#913 example, the new logs should look like this:

[etcd] Jul 30 20:50:13.509 INFO      | app02: leader changed from 'app03' to ' '.
[etcd] Jul 30 20:50:13.509 INFO      | app02: leader changed from ' ' to 'app01'.

I think the empty is correct because it signals that the leader changed to no leader so we should expect a state change to follow (e.g. follower is promoted to candidate or new leader is assigned).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.4.6 Leader logging
2 participants