Add xDS client version cache #873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 🥳 Build Id: 01011c43-d5ef-44d1-9bf3-8b4b9ceb003e The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
reviewed
Nov 28, 2023
| @@ -259,6 +259,9 @@ mod tests { | |||
| }; | |||
|
|
|||
| #[tokio::test] | |||
| // Currently pretty flaky, we still have an agones integration test for this | |||
| // use-case that will catch it. | |||
| #[ignore] | |||
There was a problem hiding this comment.
Making a note that I should look at this flake as well with the work I'm doing on #877 - is likely the same I expect.
|
Closing, since we now have delta xDS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.