Agones GameServer + Quilkin sidecar test #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/feature
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh,
vallfors and
bombsimon
as code owners
Implements an integration test wherein we use Quilkin as a sidecar to an Agones GameServer container. Also includes some updates to the test harnesses: * Function to create a common Quilkin container * Fixed odd (?) bug where k8s client would sometimes close at the end of tests, failing subsequent other tests. * Convenience function for grabbing the address of a GameServer so you can send packets to it. Work on googleforgames#510
markmandel
force-pushed
the
agones/gameserver_sidecar
branch
from
725ac95 to
50aa427
Compare
|
Build Succeeded 🥳 Build Id: 01088077-46c5-4660-a93b-ffdc0326e4ca To build this version: |
XAMPPRocky
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Implements an integration test wherein we use Quilkin as a sidecar to an
Agones GameServer container.
Also includes some updates to the test harnesses:
Which issue(s) this PR fixes:
Work on #510
Special notes for your reviewer: