Dev: Build, Push and Test Agones Integrations #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds out the `build/Makefile` tooling such that you can build, push and test the Quilkin Agones integration against either Minikube or a hosted Kubernetes cluster (tested against GKE + Artifact Registry) in one operation. Also includes: * Refactoring such that variable naming across `cargo test` and `make` targets all lined to up to be consistent. * If `IMAGE_TAG` is not present in `cargo test`, panic. * Upgrade Agones version in Terraform script. * Update release cloudbuild.yaml - include an update to changelog generator, as I found a bug in the version we were using. * More aggressive .dockerignore. Got the build context down from >3GB to ~900M, which was a big improvement in image creation speed. Work on googleforgames#510
markmandel
added
kind/feature
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh and
bombsimon
as code owners
markmandel
commented
Jul 21, 2022
| #### Minikube | ||
|
|
||
| This target assumes that you have a [working minikube cluster](#creating-an-agones-minikube-cluster), | ||
| under the profile `quilkin`, with Agones installed, and the local `.kube` configuration is currently |
There was a problem hiding this comment.
In the Agones minikube documentation, it directs you to use a profile named agones.
I went in the direction to push people to keep the Quilkin testing separate from other things, so picked a different default profile for these targets -- but what do you think, should it be agones ?
Can also change it later if it starts to annoy people.
XAMPPRocky
approved these changes
Jul 21, 2022
|
Build Succeeded 🥳 Build Id: 2002649c-ebb5-45c2-b7a9-61df74c9bc4f To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This builds out the
build/Makefiletooling such that you can build, push and test the Quilkin Agones integration against either Minikube or a hosted Kubernetes cluster (tested against GKE + Artifact Registry) in one operation.Also includes:
cargo testandmaketargets all lined to up to be consistent.IMAGE_TAGis not present incargo test, panic.Which issue(s) this PR fixes:
Work on #510
Special notes for your reviewer:
Once this is merged, I can work on integrating it with our CI builds.