fix: use modernized and standardized OpenTelemetry when tracing #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
odeke-em
force-pushed
the
trace-use-standardized-opentelemetry-attributes
branch
3 times, most recently
from
dc7d3ae
to
a045aa5
Compare
odeke-em
changed the title
odeke-em
force-pushed
the
trace-use-standardized-opentelemetry-attributes
branch
8 times, most recently
from
ad15b89
to
b43e4f1
Compare
product-auto-label
bot
added
size: l
odeke-em
force-pushed
the
trace-use-standardized-opentelemetry-attributes
branch
8 times, most recently
from
8aadc02
to
47f5b3d
Compare
|
@harshachinta is it possible for you to hep me authorize workflows to have the tests running on every push? Thank you. |
odeke-em
force-pushed
the
trace-use-standardized-opentelemetry-attributes
branch
from
47f5b3d
to
ac63111
Compare
odeke-em
force-pushed
the
trace-use-standardized-opentelemetry-attributes
branch
from
ac63111
to
6da95a1
Compare
odeke-em
force-pushed
the
trace-use-standardized-opentelemetry-attributes
branch
from
90e36ed
to
b190663
Compare
odeke-em
force-pushed
the
trace-use-standardized-opentelemetry-attributes
branch
from
d6d6ece
to
58c8555
Compare
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 12, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 16, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
harshachinta
pushed a commit
that referenced
this pull request
Sep 18, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates #1170 Fixes #1173 Built from PR #1172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modernizes trace span attributes by using OpenTelemetry's
semantic conventions that are standardized and allow for much
better common ground adoption by broader systems, even more as
Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more.
With this change we've made the replacement of these fields, directly
with imports from
opentelemetry.semconv.trace.SpanAttributes, as:While here, also updated opentelemetry-(api, sdk) dependencies to use
versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0"
Also added in an option toggled by environment variable
which allows spans to be annotated with the SQL statement keyed by
Fixes #1170
Fixes #1171
Fixes #1173
Exhibit
With the change made, we now have this trace with attributes visualized from Google Cloud Tracing per
