Address code review feedback

googleapis · Oct 7, 2024 · 3c0c421 · 3c0c421
1 parent aadb961
commit 3c0c421
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/google/cloud/spanner_v1/session.py b/google/cloud/spanner_v1/session.py
@@ -32,7 +32,6 @@
 )
 from google.cloud.spanner_v1._opentelemetry_tracing import (
     get_current_span,
-    set_span_error_and_record_exception,
     trace_call,
 )
 from google.cloud.spanner_v1.batch import Batch
@@ -117,11 +116,10 @@ def name(self):
         :raises ValueError: if session is not yet created
         """
         if self._session_id is None:
-            err = "No session available"
+            err_message = "No session ID set by back-end"
             current_span = get_current_span()
-            current_span.add_event(err)
-            set_span_error_and_record_exception(current_span, err)
-            raise ValueError("No session ID set by back-end")
+            current_span.add_event(err_message)
+            raise ValueError(err_message)
         return self._database.name + "/sessions/" + self._session_id
 
     def create(self):
@@ -136,10 +134,9 @@ def create(self):
         current_span.add_event("Creating Session")
 
         if self._session_id is not None:
-            err = "Session ID already set by back-end"
-            current_span.add_event(err)
-            set_span_error_and_record_exception(current_span, err)
-            raise ValueError(err)
+            err_message = "Session ID already set by back-end"
+            current_span.add_event(err_message)
+            raise ValueError(err_message)
         api = self._database.spanner_api
         metadata = _metadata_with_prefix(self._database.name)
         if self._database._route_to_leader_enabled: