Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(generator/go): add an integration test for golang generation #961

Closed
wants to merge 6 commits into from

Conversation

devoncarew
Copy link
Collaborator

  • add an integration test for golang generation

When looking at adding a Dart backend, I'd copied the Go one (from a few days ago), but noticed that it was no longer working; the templates directory location had changed as well as several of the mustache variable names. This PR adds an integration test for the golang generator as a github workflow. It's not 100% functional, as the generation code doesn't go build:

# secretmanager
./client.go:1112:5: undefined: Metadata
./client.go:1147:17: undefined: Time
./client.go:1168:17: undefined: Time
./client.go:1171:10: undefined: Duration
./client.go:1213:24: undefined: Duration
...

but perhaps this test is useful as a start? The fixes are probably pretty straightforward for someone w/ more go experience.

@devoncarew
Copy link
Collaborator Author

From the CI failures it looks like I need to update the goldens for generator/testdata/go/protobuf/golden/iam/v1/go.mod. I can do that, but I'm wondering if I should use that api as the one to use for an integration test?

@devoncarew devoncarew changed the title test(generator/go) add an integration test for golang generation test(generator/go): add an integration test for golang generation Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (56c7a5b) to head (d070792).
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          36       36           
  Lines        1369     1369           
=======================================
  Hits         1309     1309           
  Misses         60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devoncarew devoncarew marked this pull request as draft February 3, 2025 17:36
@devoncarew
Copy link
Collaborator Author

closing for now -

@devoncarew devoncarew closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant