Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fail the build on clippy warnings #91

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 5, 2024

TIL: without --fix clippy fails silently, with --fix at least we get failures in the git diff command.

@coryan coryan marked this pull request as ready for review November 5, 2024 00:42
@coryan coryan requested a review from julieqiu November 5, 2024 16:26
@coryan coryan merged commit b5ec48a into googleapis:main Nov 5, 2024
9 checks passed
@coryan coryan deleted the ci-automatically-apply-clippy-changes branch November 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants