Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure sidekick to always use wkt #847

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 25, 2025

Fixes #846

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (25149ad) to head (521cb66).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          36       36           
  Lines        1357     1357           
=======================================
  Hits         1297     1297           
  Misses         60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review January 25, 2025 16:22
@coryan coryan requested a review from codyoss January 25, 2025 16:22
@coryan coryan merged commit dfa4167 into googleapis:main Jan 26, 2025
15 checks passed
@coryan coryan deleted the fix-configure-sidekick-to-always-use-wkt branch January 26, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Must import wkt crate if any message is present
2 participants