feat(generator/rust): improve setters #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 36 36
Lines 1357 1357
=======================================
Hits 1297 1297
Misses 60 60 ☔ View full report in Codecov by Sentry. |
coryan
commented
Jan 24, 2025
codyoss
approved these changes
Jan 27, 2025
The setters for `Vec<T>` fields now consume a `IntoIterator<Item = V>` where `V` implements `Into<T>`. Similarly, the setters for `HashMap<K, V>` fields consume a `IntoIterator<Item = (KI, VI)>` where `KI` and `VI` do what you expect. I changed the integration tests to take advantage of this change. Since I was changing all the setters, I also updated their comments to directly link the field they are changing. That makes it easier to navigate to a description of the field.
coryan
force-pushed
the
feat-generator-rust-into-iterator
branch
from
958d517 to
d78f04e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setters for
Vec<T>fields now consume aIntoIterator<Item = V>whereVimplementsInto<T>. Similarly, the setters forHashMap<K, V>fieldsconsume a
IntoIterator<Item = (KI, VI)>whereKIandVIdo what youexpect.
I changed the integration tests to take advantage of this change.
Since I was changing all the setters, I also updated their comments to directly
link the field they are changing. That makes it easier to navigate to a
description of the field.
Fixes #627 and fixes #461. Related to #460.