Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ci): use tf variable where possible #805

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jan 23, 2025

Someone is copying the terraform configuration, but with a different project. They noticed the project name could be substituted here.

variable "project" {
default = "rust-sdk-testing"
}

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (b412e6c) to head (4b2cb3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          36       36           
  Lines        1357     1357           
=======================================
  Hits         1297     1297           
  Misses         60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review January 23, 2025 21:42
@dbolduc dbolduc merged commit 56b4361 into googleapis:main Jan 23, 2025
14 checks passed
@dbolduc dbolduc deleted the cleanup-terraform-variable branch January 23, 2025 21:42
dbolduc added a commit that referenced this pull request Jan 24, 2025
dbolduc added a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants