feat(generator): support self-referential fields #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 36 36
Lines 1357 1357
=======================================
Hits 1297 1297
Misses 60 60 ☔ View full report in Codecov by Sentry. |
coryan
force-pushed
the
feat-generator-support-recursive-fields
branch
2 times, most recently
from
8ee4822 to
3eb8ba7
Compare
codyoss
approved these changes
Jan 24, 2025
Message fields may refer to the same message, directly or indirectly. With this change the fields gain a `Recursive` attribute, set to `true` if the field directly (or indirectly) references the containing message. The Rust Codec uses this attribute to emit `Option<Box<T>>` instead of `Option<T>` for such fields. In the process I found some mistakes in the handling of map types with objects in them.
coryan
force-pushed
the
feat-generator-support-recursive-fields
branch
from
3eb8ba7 to
1f6aae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message fields may refer to the same message, directly or indirectly.
With this change the fields gain a
Recursiveattribute, set totrueif the field directly (or indirectly) references the containing message.
The Rust Codec uses this attribute to emit
Option<Box<T>>instead ofOption<T>for such fields.Fixes #586