-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl: devtools/cmd/generate,testdata: add command to run protoc-gen #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not merge the files that we are not going to use (**/BUILD.bazel
and **_grpc_service_config.json
. Maybe there is a good reason to merge them?
We also seem to have 3 different ways to generate the golden files now: this, my changes in #66, and the explicit call to protoc
.
generator/testdata/google/cloud/secretmanager/logging/v1/BUILD.bazel
Outdated
Show resolved
Hide resolved
generator/testdata/google/cloud/secretmanager/logging/v1/secret_event.proto
Outdated
Show resolved
Hide resolved
generator/testdata/google/cloud/secretmanager/v1/secretmanager_grpc_service_config.json
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,31 @@ | |||
// Copyright 2015 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the metaphysical discussion around what is the copyright year for a copy of a file. LOL.
Alternative: we could use a git submodule and reference github.com/googleapis/googleapis
instead of copying a few files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered this option but I thought that it might be nice to just limit to the set of files we need so the input is clear. Happy to change this later on though
What do you think about moving everything under We could have the structure:
I can move this in a follow up PR if that seems good to you. |
A single location SGTM. In case you missed this: we will need more than one |
No description provided.