Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/protoc-gen-gclient: factor out captureInput #70

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

julieqiu
Copy link
Member

@julieqiu julieqiu commented Nov 1, 2024

Move logic for captureInput to a separate function and document it.

@julieqiu julieqiu force-pushed the julie-pr3 branch 2 times, most recently from d4a57cf to 10169c0 Compare November 2, 2024 00:14
@julieqiu julieqiu requested a review from codyoss November 2, 2024 18:23
@julieqiu julieqiu force-pushed the julie-pr3 branch 2 times, most recently from 1d6ec84 to 9ee6f91 Compare November 4, 2024 04:13
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

generator/cmd/protoc-gen-gclient/main_test.go Outdated Show resolved Hide resolved
Move logic for captureInput to a separate function and document it.
@julieqiu julieqiu enabled auto-merge (squash) November 4, 2024 18:46
@julieqiu julieqiu merged commit 67f7c88 into main Nov 4, 2024
14 checks passed
@julieqiu julieqiu deleted the julie-pr3 branch November 4, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants