impl(internal/language): refactor TestGo_MessageNames #664
+27
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor `TestGo_MessageNames` into a parameterized test, and remove the use of `newTestAPI` since the `state` argument is unnecessary. The `state` parameter exists solely because `GoCodec` needs to implement the `Codec` interface. Additionally, explicitly document that `state` is not utilized by either `GoCodec.MessageName` or `GoCodec.FQMessageName`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 31 31
Lines 1181 1181
=======================================
Hits 1128 1128
Misses 53 53 ☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
TestGo_MessageNamesinto a parameterized test, and remove the use ofnewTestAPIsince thestateargument is unnecessary. Thestateparameter exists solely becauseGoCodecneeds to implement theCodecinterface.Additionally, explicitly document that
stateis not utilized by eitherGoCodec.MessageNameorGoCodec.FQMessageName.