refactor(auth): simplify error creation #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
+ Coverage 95.36% 95.51% +0.14%
==========================================
Files 31 31
Lines 1187 1181 -6
==========================================
- Hits 1132 1128 -4
+ Misses 55 53 -2 ☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Jan 9, 2025
dbolduc
force-pushed
the
auth-cleanup-error-factory
branch
from
7f577b0 to
cfd6595
Compare
| @@ -81,15 +81,12 @@ impl TokenProvider for UserTokenProvider { | |||
| let resp = builder | |||
| .send() | |||
| .await | |||
| .map_err(|e| CredentialError::new(false, e.into()))?; | |||
| .map_err(CredentialError::non_retryable)?; | |||
There was a problem hiding this comment.
why is this error not retryable?
if it is a connection error or something like that, it should be possible to retry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce crate private error helpers, as suggested by @coryan in https://github.com/googleapis/google-cloud-rust/pull/656/files#r1909410273 and probably other places.
There is a different issue to rethink whether some of these errors are retryable or not. I am not dealing with that in this PR. I want this PR to be a pure refactor.