impl(generator): support more field types #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support more field types, including several string formats. Remove code duplication between array and scalar field handling. Make it easier to write smaller unit tests.
julieqiu
approved these changes
Nov 1, 2024
|
|
||
| func makeStringType(messageName, name, format string, optional bool, field *base.Schema) (*genclient.Field, error) { | ||
| switch format { | ||
| case "": |
There was a problem hiding this comment.
No. A normal string has no "format" field. Integers as strings have {"type": "string", "format": "int64"}.
I sure don't like how OpenAPI represents primitive types 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support more field types, including several string formats.
Remove code duplication between array and scalar field handling.
Make it easier to write smaller unit tests.