impl: start on OpenAPI prototype #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we prefer protos as an input into the generator, we want to prototype using OpenAPI as an alternative input. This PR introduces a new "translator" for OpenAPI, a rough implementation for messages and field, and some initial tests.
julieqiu
reviewed
Oct 31, 2024
| @@ -0,0 +1,75 @@ | |||
| // Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
I think that you can just name this file cmd/openapi to simplify, since this is just a regular command
generator/internal/genclient/translator/openapi/openapi_test.go
Outdated
Show resolved
Hide resolved
julieqiu
reviewed
Oct 31, 2024
generator/internal/genclient/translator/openapi/openapi_test.go
Outdated
Show resolved
Hide resolved
generator/internal/genclient/translator/openapi/openapi_test.go
Outdated
Show resolved
Hide resolved
julieqiu
approved these changes
Nov 1, 2024
generator/internal/genclient/translator/openapi/openapi_test.go
Outdated
Show resolved
Hide resolved
generator/internal/genclient/translator/openapi/openapi_test.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we prefer protos as an input into the generator, we want to prototype
using OpenAPI as an alternative input. This PR introduces a new "translator"
for OpenAPI, a rough implementation for messages and field, and some initial
tests.