Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check for license headers #55

Merged
merged 2 commits into from
Oct 31, 2024
Merged

test: check for license headers #55

merged 2 commits into from
Oct 31, 2024

Conversation

julieqiu
Copy link
Member

No description provided.

@julieqiu julieqiu requested review from codyoss and coryan October 31, 2024 03:04
"testing"
)

var googleHeader = regexp.MustCompile(`^// Copyright 2024 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will start failing next year, as we add files with "Copyright 2025".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

generator/all_test.go Show resolved Hide resolved
@codyoss
Copy link
Member

codyoss commented Oct 31, 2024

We have a bot for this, I have not used it ever though: https://github.com/googleapis/repo-automation-bots/tree/main/packages/header-checker-lint

@coryan
Copy link
Contributor

coryan commented Oct 31, 2024

We have a bot for this, I have not used it ever though: https://github.com/googleapis/repo-automation-bots/tree/main/packages/header-checker-lint

Can this robot be executed locally?

As an alternative: #58 we will need something once the generator finds its ultimate home.

@julieqiu julieqiu merged commit 3c8b542 into main Oct 31, 2024
13 checks passed
@julieqiu julieqiu deleted the julie-pr1 branch October 31, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants